Skip to content

Implemented light-dark mode theme support.#146

Open
luckcolors wants to merge 1 commit into
openscad:mainfrom
luckcolors:main
Open

Implemented light-dark mode theme support.#146
luckcolors wants to merge 1 commit into
openscad:mainfrom
luckcolors:main

Conversation

@luckcolors

Copy link
Copy Markdown

OpenSCAD Playground Pull Request

This issue solves #135 and is a refactor of pull #128.
It is based on the code from user @tekk from said pull request and for this reason i've added them as a co-author.

Changes:

  • I have cleaned up the changes to be as minimal as possible.
  • Original icons have been kept.
  • Github "fork-me" button as been restored.
  • Dark theme button has been moved to cog-whell settings menu. By default if no preference is set at application load in userstorage it uses browser theme preference.
  • Patched bundler config to include the required files from node_modules.

What kind of change does this Pull Request provide?

Please check the relevant options:

  • Bug fix
  • Enhancement
  • Documentation
  • Other (please explain):

How can the changes of the Pull Request be tested?

Application was served using readme.md production commands.

  1. The theme button was tested and confirmed to be working
  2. The auto theme detection was tested by changing the browser setting and reloading the app.

Co-authored-by: tekk <721967+tekk@users.noreply.github.com>

@ochafik ochafik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luckcolors !

Comment thread src/components/EditorPanel.tsx
Comment thread src/components/SettingsMenu.tsx

@luckcolors luckcolors left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants